Skip to content
This repository was archived by the owner on May 22, 2026. It is now read-only.

Make enums uppercase, but not break people accessing with lower case - #692

Merged
iscai-msft merged 11 commits into
autorestv3from
make_enums_uppercase
Jul 6, 2020
Merged

Make enums uppercase, but not break people accessing with lower case#692
iscai-msft merged 11 commits into
autorestv3from
make_enums_uppercase

Conversation

@iscai-msft

Copy link
Copy Markdown
Member

fixes #688

@iscai-msft
iscai-msft requested a review from lmazuel June 15, 2020 21:02
…into make_enums_uppercase

* 'autorestv3' of https://github.com/Azure/autorest.python:
  Correct variable typing in models py3 file for python 3.5 (#691)
  Data plane multiapi (#693)
  Lro and paging (iscai style) (#689)

@lmazuel lmazuel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use six.with_metaclass

@lmazuel

lmazuel commented Jun 26, 2020

Copy link
Copy Markdown
Member

@iscai-msft one last thing to check, if the enum has a "count" or "startswith" member, make sure the lowercase is the string function. Is that the case already?

Comment thread autorest/codegen/templates/enum_container.py.jinja2 Outdated
@iscai-msft
iscai-msft requested a review from lmazuel June 29, 2020 16:16
@iscai-msft
iscai-msft merged commit 9d7bb57 into autorestv3 Jul 6, 2020
@iscai-msft
iscai-msft deleted the make_enums_uppercase branch July 6, 2020 15:52
iscai-msft added a commit that referenced this pull request Jul 6, 2020
…into add_http_logging_policy

* 'autorestv3' of https://github.com/Azure/autorest.python:
  Make enums uppercase, but not break people accessing with lower case (#692)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants